<html>
<head><meta charset="utf-8"><title>pksunkara · t-compiler/help-wanted · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/212497-t-compiler/help-wanted/index.html">t-compiler/help-wanted</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/212497-t-compiler/help-wanted/topic/pksunkara.html">pksunkara</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="186044069"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/212497-t-compiler/help-wanted/topic/pksunkara/near/186044069" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pksunkara <a href="https://rust-lang.github.io/zulip_archive/stream/212497-t-compiler/help-wanted/topic/pksunkara.html#186044069">(Jan 19 2020 at 15:21)</a>:</h4>
<p>Hey, I was looking at things blocking <code>proc_macro_hygiene</code> and realized that <a href="https://github.com/rust-lang/rust/issues/55414" target="_blank" title="https://github.com/rust-lang/rust/issues/55414">https://github.com/rust-lang/rust/issues/55414</a> is labelled as E-help-wanted and E-mentor. I would love to fix this. But I have no idea where to start. <span class="user-mention" data-user-id="123856">@Vadim Petrochenkov</span> , you are the mentor, right?</p>



<a name="186045091"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/212497-t-compiler/help-wanted/topic/pksunkara/near/186045091" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/212497-t-compiler/help-wanted/topic/pksunkara.html#186045091">(Jan 19 2020 at 15:55)</a>:</h4>
<blockquote>
<p>@Vadim Petrochenkov , you are the mentor, right?</p>
</blockquote>
<p>Yes, I am!</p>



<a name="186045191"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/212497-t-compiler/help-wanted/topic/pksunkara/near/186045191" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/212497-t-compiler/help-wanted/topic/pksunkara.html#186045191">(Jan 19 2020 at 15:58)</a>:</h4>
<p>Looks like you haven't worked on <code>rustc</code> yet?<br>
The first thing to understand here is how <code>rustc</code>'s Abstract Syntax Tree is organized (<code>src\libsyntax\ast.rs</code>) and how visitor pattern is used for walking AST immutably (<code>src\libsyntax\visit.rs</code>) or mutably (<code>src\libsyntax\mut_visit.rs</code>).</p>



<a name="186045256"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/212497-t-compiler/help-wanted/topic/pksunkara/near/186045256" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/212497-t-compiler/help-wanted/topic/pksunkara.html#186045256">(Jan 19 2020 at 16:00)</a>:</h4>
<p>The <code>InvocationCollector</code>'s implementation of <code>MutVisitor</code> needs to be tweaked to implement the new behavior for attributes, this comments <a href="https://github.com/rust-lang/rust/issues/55414#issuecomment-554005412" target="_blank" title="https://github.com/rust-lang/rust/issues/55414#issuecomment-554005412">https://github.com/rust-lang/rust/issues/55414#issuecomment-554005412</a> describes some details.</p>



<a name="186045347"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/212497-t-compiler/help-wanted/topic/pksunkara/near/186045347" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/212497-t-compiler/help-wanted/topic/pksunkara.html#186045347">(Jan 19 2020 at 16:03)</a>:</h4>
<p>(Of course, before that you'll need to build rustc (<a href="https://github.com/rust-lang/rust/blob/master/README.md" target="_blank" title="https://github.com/rust-lang/rust/blob/master/README.md">https://github.com/rust-lang/rust/blob/master/README.md</a>) and be able to run tests (<code>./x.py test --bless --stage 1 src/test/ui --test-args my_test_name</code>).)</p>



<a name="186051015"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/212497-t-compiler/help-wanted/topic/pksunkara/near/186051015" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pksunkara <a href="https://rust-lang.github.io/zulip_archive/stream/212497-t-compiler/help-wanted/topic/pksunkara.html#186051015">(Jan 19 2020 at 18:57)</a>:</h4>
<p>Got the tests working. Reading through the <code>ast.rs</code> for now.</p>



<a name="186123907"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/212497-t-compiler/help-wanted/topic/pksunkara/near/186123907" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pksunkara <a href="https://rust-lang.github.io/zulip_archive/stream/212497-t-compiler/help-wanted/topic/pksunkara.html#186123907">(Jan 20 2020 at 18:24)</a>:</h4>
<p><span class="user-mention" data-user-id="123856">@Vadim Petrochenkov</span> should I add a test to <code>ui</code> folder for this issue as first step? I am asking because I am not sure where to add the test</p>



<a name="186128746"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/212497-t-compiler/help-wanted/topic/pksunkara/near/186128746" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/212497-t-compiler/help-wanted/topic/pksunkara.html#186128746">(Jan 20 2020 at 19:48)</a>:</h4>
<p>Yes, tests usually go into subdirectories of <code>test\ui</code>, e.g. <code>test\ui\attributes</code> in this case.</p>



<a name="186128996"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/212497-t-compiler/help-wanted/topic/pksunkara/near/186128996" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/212497-t-compiler/help-wanted/topic/pksunkara.html#186128996">(Jan 20 2020 at 19:52)</a>:</h4>
<p><span class="user-mention" data-user-id="254853">@pksunkara</span> The rustc-guide can be a good starting point for general rustc questions: <a href="https://rust-lang.github.io/rustc-guide/" target="_blank" title="https://rust-lang.github.io/rustc-guide/">https://rust-lang.github.io/rustc-guide/</a></p>
<p>In particular: <a href="https://rust-lang.github.io/rustc-guide/building/suggested.html" target="_blank" title="https://rust-lang.github.io/rustc-guide/building/suggested.html">https://rust-lang.github.io/rustc-guide/building/suggested.html</a> and <a href="https://rust-lang.github.io/rustc-guide/tests/intro.html" target="_blank" title="https://rust-lang.github.io/rustc-guide/tests/intro.html">https://rust-lang.github.io/rustc-guide/tests/intro.html</a> and <a href="https://rust-lang.github.io/rustc-guide/compiler-debugging.html" target="_blank" title="https://rust-lang.github.io/rustc-guide/compiler-debugging.html">https://rust-lang.github.io/rustc-guide/compiler-debugging.html</a></p>



<a name="186619047"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/212497-t-compiler/help-wanted/topic/pksunkara/near/186619047" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/212497-t-compiler/help-wanted/topic/pksunkara.html#186619047">(Jan 26 2020 at 12:14)</a>:</h4>
<p>Hi, <span class="user-mention" data-user-id="254853">@pksunkara</span>.<br>
Any news? Do you have a branch in progress so I could look at it and give some feedback?</p>



<a name="186785451"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/212497-t-compiler/help-wanted/topic/pksunkara/near/186785451" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pksunkara <a href="https://rust-lang.github.io/zulip_archive/stream/212497-t-compiler/help-wanted/topic/pksunkara.html#186785451">(Jan 28 2020 at 14:08)</a>:</h4>
<p>Unfortunately no, I have been travelling last week. I should have some stuff for you to look at this week. Sorry.</p>



<a name="187181325"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/212497-t-compiler/help-wanted/topic/pksunkara/near/187181325" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pksunkara <a href="https://rust-lang.github.io/zulip_archive/stream/212497-t-compiler/help-wanted/topic/pksunkara.html#187181325">(Feb 01 2020 at 23:36)</a>:</h4>
<p>Hey <span class="user-mention" data-user-id="123856">@Vadim Petrochenkov</span>, with the stabilisation of fn-like macros for expressions, my main reason for picking this up is gone. I am not interested in attribute macros for expressions. I would much rather focus my effort on getting <code>type_ascription</code> stable. But I really would love to get back to this sometime.</p>



<a name="187197591"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/212497-t-compiler/help-wanted/topic/pksunkara/near/187197591" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/212497-t-compiler/help-wanted/topic/pksunkara.html#187197591">(Feb 02 2020 at 09:11)</a>:</h4>
<p>Ok.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>